commit | f42119e8532429279b85836752227883fa412a45 | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Wed Apr 14 15:28:38 2021 -0400 |
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Wed Apr 14 19:48:37 2021 +0000 |
tree | 1b3d00108ed2fd6a68a9dfa47f85a6add0d0227c | |
parent | e65260dcb444b7ffd3cf4dfffff141d32c6b84e9 [diff] |
Migrate repository to a single package.json file. File //package.json now contains the union of all other package.json files, with most NPM packages updated to their latest versions. Files //html-template-minifier/package.json and //jsdoc/package.json remain unchanged. All other package.json files are deleted. Minor changes to some JS/TS files were necessary after updating the NPM packages. I added a //make/npm.mk file that defines an npm-ci make target that can be added as a prerequisite to any targets that depend on the node_modules directory. Added some apps to CI (see changes in //Makefile). Nearly all changes to BUILD.bazel file are automatic (Gazelle). Steps I took to generate //package.json: # Compute the list of target package.json files. $ allpackagejson=`find | grep "package\.json$" | grep -v html-template-minifier | grep -v jsdoc | grep -v node_modules | grep -v bower_components | grep -v .git | sort` # Collect all NPM packages packages from all package.json files. $ allpkgs=`jq -r '(.dependencies // {}) + (.devDependencies // {}) | keys | .[]' $allpackagejson | sort | uniq` # Uninstall all NPM packages from //package.json. $ npm uninstall `jq -r '(.dependencies // {}) + (.devDependencies // {}) | keys | .[]' package.json` # Delete all other package.json and package-lock.json files. $ git rm `find | grep "package\.json$" | grep -v ^./package.json$ | grep -v html-template-minifier | grep -v jsdoc | grep -v node_modules | grep -v bower_components | grep -v .git` $ git rm `find | grep package-lock.json | grep -v ^./package-lock.json$ | grep -v html-template-minifier | grep -v jsdoc | grep -v node_modules | grep -v bower_components | grep -v .git` # Install all collected packages at their most recent version. $ npm install $allpkgs # Reinstall some packages at specific versions. $ npm install webpack@^4.0.0 @types/webpack@^4.0.0 $ npm install webpack-dev-middleware@^3.0.0 @types/webpack-dev-middleware@^3.0.0 $ npm install webpack-dev-server@^3.0.0 @types/webpack-dev-server@^3.0.0 $ npm install webpack-cli@^3.0.0 $ npm install mini-css-extract-plugin@^0.9.0 @types/mini-css-extract-plugin@^0.9.0 $ npm install html-webpack-plugin@^4.0.0 $ npm install copy-webpack-plugin@^5.0.0 @types/copy-webpack-plugin@^5.0.0 $ npm install node-sass@^4.0.0 sass-loader@^7.0.0 $ npm install postcss-loader@^2.0.0 $ npm install autoprefixer@^9.0.0 $ npm install html-loader@^0.5.5 $ npm install cssnano@^3.0.0 $ npm install karma@^4.0.0 @types/karma@^4.0.0 $ npm install karma-webpack@^4.0.0 $ npm install sinon@^7.0.0 @types/sinon@^7.0.0 $ npm install d3-selection@^1.0.0 $ npm install @bazel/rollup@~2.0.0 @bazel/terser@~2.0.0 @bazel/typescript@~2.0.0 $ npm install @rollup/plugin-commonjs@~15.0.0 @rollup/plugin-node-resolve@~9.0.0 $ npm install terser@^5.0.0 # Uninstall unneeded packages. $ npm uninstall @bundled-es-modules/fetch-mock @types/fetch-mock $ npm uninstall terser-webpack-plugin Bug: skia:10614 Change-Id: I342f0c950af313752025087e70fd2b2d6fa6a709 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/395916 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
Get mockery and add it to your PATH.
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small