commit | 7528abece04da65593b40900123f2e16ec8ac386 | [log] [tgz] |
---|---|---|
author | Joe Gregorio <jcgregorio@google.com> | Tue Jul 26 12:59:38 2022 -0400 |
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Tue Jul 26 17:42:39 2022 +0000 |
tree | 035a5e2a6af0914d7c4929d849971e1be58951f0 | |
parent | 9db87857d708a1c549befaea3100342b8d181562 [diff] |
[perf] Fix bug in trace key validation. One of the tests for a Valid Key is that keys in the trace id are in sorted order, which they are in: ",browser=chrome,browser-version=106.0.5196.0,channel=canary,sub-test=date-format-xparb-SP," and they are, but the validation code didn't strip off the "=<value>" from the keys before checking that they are in sorted order so "browser" comes before "browser-version" but "browser=chrome" does not come before "browser-version=106.0.5196.0" Change-Id: Iac9cb23dd55ce09084d1b2cdf09aafe9ffd36c5b Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/562476 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install \ jq \ python-django $ go get -u \ github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate \ go get github.com/mikefarah/yq/v4
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small