| commit | 72e15449cf8c852c503c28251c0e1d97ee71b5f6 | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Fri May 08 11:27:49 2020 -0400 |
| committer | Kevin Lubick <kjlubick@google.com> | Fri May 08 18:01:20 2020 +0000 |
| tree | f5d69a99bd7545e062046f4c77bcce6a3f4d8552 | |
| parent | c4812a5ad9109058f875f1c7a7180dd116dbf31d [diff] |
[gold] Add settings util This consolidates the way to get global constants into (potentially nested) elements. In the Polymer version, Gold would inject variables from the server side into the html by templating some JS and creating a global sk.app_config variable. [1], [2]. Up to this point, the lit-html pages have only need data that was fine to be passed in to the top level. [3] However, now that we need BaseRepo to link to the source code, trickling down all variables we need seems overly complicated and an unnecessary breakdown in abstraction. This is a similar approach to the app_config approach, except we add a helper function to access the methods instead of having a lot of magic "window level variables" all over the place. [1] https://github.com/google/skia-buildbot/blob/8387de40b46b3df28f0b11145244c4083ee10d30/golden/frontend/index.html#L13 [2] https://github.com/google/skia-buildbot/blob/8387de40b46b3df28f0b11145244c4083ee10d30/golden/cmd/skiacorrectness/main.go#L545 [3] https://github.com/google/skia-buildbot/blob/8387de40b46b3df28f0b11145244c4083ee10d30/golden/pages/diff.html#L8 Bug: skia:9525 Change-Id: I5c1956efeed4cca01adfea6a2f39880d245494d6 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/288554 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small