commit | 2cbe10b09a0d15026b685a5677b3ee13d14e9c26 | [log] [tgz] |
---|---|---|
author | Kevin Lubick <kjlubick@google.com> | Thu Oct 24 08:13:16 2019 -0400 |
committer | Kevin Lubick <kjlubick@google.com> | Thu Oct 24 14:06:22 2019 +0000 |
tree | 8c4771f88b6d38c790bce76505a7d6d00d9b74f8 | |
parent | a23d9303644add41dccb24694410b26941a6e13e [diff] |
[gold] Introduce expectations.ReadOnly to use fewer copies. This is a big change - now instead of clients getting an unchanging copy of the expectations when they ask the Store for it, they are getting a pointer to the current state of expectations. For example, if someone triages something, firestore sends a notification (via the QuerySnapshots in fs_expstore), which will modify the source of truth (fs_expstore.cache), which in turn updates the version for all clients (in a thread-safe way, if all the mutexes line up). This should reduce latency in many cases, because the ~300ms needed to copy all the expectations for Skia adds up. Additionally, it should reduce the amount of RAM needed, by avoiding so many of those copies. GetCopy preserves the old functionality for the few clients that needed to modify the expectations after fetching (simple_baseliner) Bug: skia:9557, skia:9080 Change-Id: Ie21c985cba9ffc37306b2ce1eafa46c6df334326 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/250236 Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small