[gold] Preparing to remove datastore-backed ExpectationsStore

Notes to the reviewer:
 - PS 1-2 removes IssueExpStoreFactory and replace it with a method on
   ExpectationsStore.
 - PS 3+ fills out the IssueExpectations implementation on Firestore.
 - PS 3+ also makes the Firestore impl use eventbus like the DS
   version did

Bug: skia:9090
Change-Id: I32e90bb3d301164344fd9f3a99e50a8978a8a8fb
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/218557
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
24 files changed
tree: fd6dd5679905de9e3407b3745a5d2e62e2f25446
  1. am/
  2. android_compile/
  3. android_ingest/
  4. android_stats/
  5. api/
  6. appengine_scripts/
  7. autoroll/
  8. bash/
  9. blamer/
  10. chromeextensions/
  11. cmd/
  12. comments/
  13. common-sk/
  14. contestk/
  15. cq_watcher/
  16. ct/
  17. datahopper/
  18. debugger/
  19. debugger-assets/
  20. docker/
  21. docserverk/
  22. ds/
  23. fiddlek/
  24. firestore/
  25. fuzzer/
  26. get_service_account/
  27. git_cookie_authdaemon/
  28. gitsync/
  29. go/
  30. gold-client/
  31. golden/
  32. grafana/
  33. html-template-minifier/
  34. infra/
  35. infra-sk/
  36. jsdoc/
  37. jsfiddle/
  38. k8s_checker/
  39. kube/
  40. leasing/
  41. licenses/
  42. logmetrics/
  43. make/
  44. monitoring/
  45. named-fiddles/
  46. notifier/
  47. particles/
  48. perdiff/
  49. perf/
  50. periodic-trigger/
  51. power/
  52. prober/
  53. proberk/
  54. prometheus/
  55. promk/
  56. proxy/
  57. pulld/
  58. push/
  59. res/
  60. scripts/
  61. sheriff_emails/
  62. skfe/
  63. skolo/
  64. skottie/
  65. status/
  66. task_driver/
  67. task_scheduler/
  68. tools/
  69. tracedb/
  70. velero/
  71. webtools/
  72. .gitattributes
  73. .gitignore
  74. build_infra_prod.sh
  75. codereview.settings
  76. DATASTORE.md
  77. DEPS
  78. go.mod
  79. go.sum
  80. launch.md
  81. LICENSE
  82. Makefile
  83. PRESUBMIT.py
  84. PRIVACY_POLICY.md
  85. README.md
  86. run_unittests
  87. run_unittests.go
  88. STYLEGUIDE.md
  89. whitespace.txt
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git

or

$ go get -u -t go.skia.org/infra/...

The latter fetches the repository into your $GOPATH directory along with all the Go dependencies, while the former allows you to work in whatever directory you want. If you're working within GOPATH, you probably want to set this variable:

export GO111MODULE=on

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate
$ npm install -g polylint bower

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \
  github.com/vektra/mockery/...

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

The installed python-django version must be >= 1.7. Run the following to update:

$ sudo pip install Django --upgrade

Use this command to run the presubmit tests:

$ ./run_unittests --small