commit | 920ca3b02e4a5cfe1553e4233caaa4edfe20fb84 | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Wed Mar 25 18:17:21 2020 -0400 |
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Thu Mar 26 17:31:31 2020 +0000 |
tree | fa464dace79b9b84eb6abe2da2c55842d8b88c32 | |
parent | 81b15bfb7ae23e0b2f96fecb098db2a75079f7c6 [diff] |
[goldctl] Clean up imgmatching package. This CL aims to shorten various names to make the code easier to read. Summary of changes: - Renamed AlgorithmOptionalKey to AlgorithmNameOptKey to emphasize its relation with the AlgorithmName type. - Renamed AlgorithmParameterOptionalKey to AlgorithmParamOptKey for brevity and consistency with the above rename. - Dropped the prefixed algorithm name from constants for algorithm parameters, e.g. FuzzyMatchingMaxDifferentPixels is now just MaxDifferentPixels. - Renamed fuzzy.FuzzyMatcher to fuzzy.Matcher. - Renamed sobel.SobelFuzzyMatcher to sobel.Matcher. Bug: skia:9527 Change-Id: I3a4d78ffe01d3347314134a04f8ec6606888ace7 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/279019 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small