commit | 57aedfc0108fc4a05114e63d2ca4f1df99b723b9 | [log] [tgz] |
---|---|---|
author | Weston Tracey <westont@google.com> | Thu Oct 22 16:17:23 2020 -0400 |
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri Oct 23 11:39:39 2020 +0000 |
tree | f51a83a3c71e86153296fc4da7eec3be4af970f1 | |
parent | 009fd626f6d6333e2f9d60a3cab0adefb93c5207 [diff] |
[status] Keep comment icons on commit toggle. --Wrap commit-text so innerHTML doesn't clobber icons --Also update commit styles to better handle longer/wrapped subjects interacting with icons --Inverted order of icon addition to keep it the way it is now (reverts and relands to the left) since we no longer float the icons.) Change-Id: I3230823babab8bb32da3cb98a51628d258e2e46b Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/329225 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Weston Tracey <westont@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small