| commit | 4e63c3caefb6dfa784a2024d0c8f3a2204cfddd2 | [log] [tgz] |
|---|---|---|
| author | Ravi Mistry <rmistry@google.com> | Thu Oct 08 15:17:15 2020 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri Oct 09 13:19:19 2020 +0000 |
| tree | 3c61524441683027ab87a08dd068d61e4cee2bcb | |
| parent | 2122393c0b6872232e57f6c8a88eda2398950153 [diff] |
[am] New 'Add bot' button At the start of trooper shifts the trooper typically creates a silence for bots that require an office trip. Then subsequent bot alerts have to be manually added to the silence. This feature makes adding new bot alerts to an existing silence easy. New 'Add bot' button next to the bot param for bot-centric silences: https://screenshot.googleplex.com/8rVumhC4csg9ucZ Clicking on the button will display all bots with active alerts: https://screenshot.googleplex.com/3PYa6Wbu22XygNX The list of active alerts is filtered against what is currently in the silence to avoid clicking the same bot twice. When no active bot alerts are found it displays: https://screenshot.googleplex.com/9rm6p2xEXn8c45y Caveat- Cannot select multiple bots in the select. Couldn't get this to quickly work. But hopefully not a big deal. Bug: skia:10733 Change-Id: I496126d665fb91bd33c1a6e3c79938b863d9df56 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/322596 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small