| commit | 25f0bc876287d0088695e44d12630e31ae2a6377 | [log] [tgz] |
|---|---|---|
| author | Eduardo Yap <eduardoyap@google.com> | Thu Jun 06 18:27:41 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Thu Jun 06 18:59:15 2024 +0000 |
| tree | fc975c4a3f98fdb4af8f8ffd90e9f6aed351a28c | |
| parent | ada90dae968f938d9af3f43889f9ca92fdf05711 [diff] |
Modify /_/nextParamList/ to return empty ParamSet if nextParam is not found. Valid tests don't necessarily have values for all keys in a ParamSet. For example, in the Chromeperf case, some tests don't have subtest_2 values. In the case where subtest_2 doesn't exist, nextParamList should return empty rather than fail. TestPickerSk is modified to handle this case. If the returned nextParam is empty, it'll simply not expand the next child field. Bug: b/340936382 Change-Id: Ib5e8aea40372270e20aa4a97c20498974a55bd44 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/862393 Reviewed-by: Ashwin Verleker <ashwinpv@google.com> Commit-Queue: Eduardo Yap <eduardoyap@google.com> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small