commit | ead27a89ac001b1acf154c309ab2cd8b23ffc820 | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Mon Aug 07 16:01:49 2023 +0000 |
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Mon Aug 07 16:23:48 2023 +0000 |
tree | 7ea6fc8f3f7dd429c414d5e858aaa07f3d0cf967 | |
parent | 89658e42bb911122c8c0056ae67e2bb80d7ddf34 [diff] |
ephemeral_storage.go: Fix test_machine_monitor panic on Windows. Currently the ephemeral storage monitoring routine is making test_machine_monitor panic and crash on Windows because /tmp does not exist on said OS. Specifically, the filepath.Walk() callback ignores the err argument and calls info.IsDir(), which causes a nil pointer dereference because info is nil. This CL tries to prevent the aforementioned panic by checking the err argument in the filepath.Walk() callback, and before that, it falls back to os.TempDir() if /tmp does not exist. Bug: b/40045300 Change-Id: I62fcf87325d30071817f3f9319f4dfbf7d5cdb12 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/736745 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Eric Boren <borenet@google.com> Auto-Submit: Leandro Lovisolo <lovisolo@google.com> Commit-Queue: Eric Boren <borenet@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small