Google Git
Sign in
skia / buildbot / 320f273a3e88a79d061bdd90ee6ad0d515e9c23a
commit320f273a3e88a79d061bdd90ee6ad0d515e9c23a[log] [tgz]
authorWenbin Zhang <wenbinzhang@google.com>Fri Aug 23 16:51:30 2024 -0700
committerSkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com>Sat Aug 24 00:41:57 2024 +0000
tree63168cacacd65b6b6a4b70187943c50df158ec1f
parent60d83eb668a13e0026207296db357b5c09da9751 [diff]
[chromeperf] fix when findTopAnomalies requires more than the group has

Fixing errors in production like:
panic: runtime error: index out of range [2] with length 2

goroutine 62 [running]:
go.skia.org/infra/perf/go/anomalygroup/service.(*anomalygroupService).FindTopAnomalies(0xc000d85e90, {0x16e5d90, 0xc000c4e600}, 0xc00098a840)
	perf/go/anomalygroup/service/service.go:187 +0xd37
go.skia.org/infra/perf/go/anomalygroup/proto/v1._AnomalyGroupService_FindTopAnomalies_Handler.func1({0x16e5d90, 0xc000c4e600}, {0x13a8de0?, 0xc00098a840})
	perf/go/anomalygroup/proto/v1/anomalygroup_service_grpc.pb.go:235 +0x72
go.skia.org/infra/perf/go/backend.(*Backend).initialize.(*ServerPolicy).UnaryInterceptor.func1({0x16e5d90, 0xc000c4e600}, {0x13a8de0, 0xc00098a840}, 0xc000a00420, 0xc000992c78)
	go/grpcsp/authorization.go:133 +0x277

Bug: b/357619045
Change-Id: I8f1c675efec17f660f705a714048a9304ca3ed4e
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/892886
Reviewed-by: Ashwin Verleker <ashwinpv@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
1 file changed
tree: 63168cacacd65b6b6a4b70187943c50df158ec1f
  1. am/
  2. android_ingest/
  3. android_stats/
  4. api/
  5. autoroll/
  6. bash/
  7. bazel/
  8. blamer/
  9. bugs-central/
  10. cabe/
  11. cd/
  12. cherrypick-watcher/
  13. cmd/
  14. codereview-watcher/
  15. codesize/
  16. comments/
  17. cq_watcher/
  18. ct/
  19. datahopper/
  20. debugger-app/
  21. demos/
  22. docker/
  23. docker_pushes_watcher/
  24. docs/
  25. docsyserver/
  26. ds/
  27. elements-sk/
  28. email/
  29. external/
  30. fiddlek/
  31. firestore/
  32. get_service_account/
  33. gitsync/
  34. go/
  35. gold-client/
  36. golden/
  37. helloworld/
  38. infra/
  39. infra-sk/
  40. jsdoc/
  41. jsfiddle/
  42. k8s-checker/
  43. k8s-deployer/
  44. kube/
  45. leasing/
  46. licenses/
  47. machine/
  48. make/
  49. modules/
  50. named-fiddles/
  51. new_element/
  52. npm-audit-mirror/
  53. perdiff/
  54. perf/
  55. periodic-trigger/
  56. pinpoint/
  57. proberk/
  58. promk/
  59. puppeteer-tests/
  60. sa-keys-checker/
  61. scrap/
  62. scripts/
  63. shaders/
  64. sk/
  65. skbug/
  66. skcq/
  67. skfe/
  68. skolo/
  69. skottie/
  70. static_server/
  71. status/
  72. task_driver/
  73. task_scheduler/
  74. temporal/
  75. test-service/
  76. tool/
  77. tools/
  78. tree_status/
  79. trybot_updater/
  80. .bazelignore
  81. .bazelrc
  82. .bazelversion
  83. .eslintrc.js
  84. .gitattributes
  85. .gitignore
  86. .mockery.yaml
  87. .npmrc
  88. .prettierignore
  89. .prettierrc.json
  90. .puppeteerrc.js
  91. .vpython
  92. BAZEL_CHEATSHEET.md
  93. BUILD.bazel
  94. build_infra_prod.sh
  95. CDB.md
  96. cipd.ensure
  97. codereview.settings
  98. DATASTORE.md
  99. demopage.sh
  100. DEPS
  101. go.mod
  102. go.sum
  103. go_repositories.bzl
  104. karmatest.sh
  105. launch.md
  106. LICENSE
  107. Makefile
  108. OWNERS
  109. package-lock.json
  110. package.json
  111. pnpm-lock.yaml
  112. PRESUBMIT.py
  113. PRIVACY_POLICY.md
  114. README.md
  115. STYLEGUIDE.md
  116. tools.go
  117. tsconfig.json
  118. whitespace.txt
  119. WORKSPACE
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Supported Infrastucture Platforms

The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Install dependencies

Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:

go install github.com/bazelbuild/bazelisk@latest
go install github.com/bazelbuild/buildtools/buildifier@latest
go install github.com/kisielk/errcheck@latest
go install golang.org/x/tools/cmd/goimports@latest
go install github.com/mikefarah/yq/v4@latest
go install go.chromium.org/luci/client/cmd/...@latest

Add bazelisk to path

export PATH=$PATH:$(go env GOPATH)/bin

Install other dependencies:

sudo apt-get install jq

Build ~everything

bazelisk build --config=mayberemote //...

Test everything

bazelisk test --config=mayberemote //...

Generated Code

To update generated code run the following in any directory:

go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

./run_unittests --small