| commit | 32030e34124d0d756b3fb08c5448e80627e7228a | [log] [tgz] |
|---|---|---|
| author | Leandro Lovisolo <lovisolo@google.com> | Tue Jul 07 20:15:39 2020 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Wed Jul 08 17:11:25 2020 +0000 |
| tree | 62ed3eefc0b3716e59edaaad3d2ae243b57d498a | |
| parent | 1b9f11dac68a05704a0e8e81a24979ee2e35b3f6 [diff] |
[infra-sk] Add PageObjectElement class. PageObjectElement is a very thin wrapper around either a DOM node or a Puppeteer element handle. It allows writing composable page objects[1] that can be used on in-browser tests, as well as on Puppeteer tests. Main benefits: - Portability: A page object FooPO for a web component Foo can be used to interact with Foo's UI from both foo_test.ts (i.e. in-browser tests) and foo_puppeteer_test.ts (i.e. Puppeteer tests). - Composability / code reuse: If component Bar has a component Foo, BarPO can be composed from FooPO. No need to repeat any query selectors for Foo's elements. - Less brittle tests: If Foo's HTML changes, only FooPO's query selectors need to be updated. - Higher level tests: Write fooPO.getFirstName(), fooPO.setLastName(lastName), fooPO.clickSubmitBtn(), etc. In addition, an abstract PageObject convenience base class is included to facilitate writing page objects (i.e. the base class for the FooPO and BarPO objects in the above examples). See the downstream CL https://skia-review.googlesource.com/c/buildbot/+/300217 for an example of a component with a page object used both from its in-browser and Puppeteer tests. See PageLoader[2] for a similar idea in the Dart language. Recommended review order: - page_object_element.ts - page_object_element_test_cases.ts - page_object_element_test.ts - page_object_element_puppeteer_tests.ts - page_object.ts [1] https://martinfowler.com/bliki/PageObject.html [2] https://github.com/google/pageloader Change-Id: I2db4fdf120a3d94bdc435e208f193b41dea9e0a3 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/300213 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small