| commit | 6694a81da5af7cd6256304d54e42c5fa130ed619 | [log] [tgz] |
|---|---|---|
| author | Eric Boren <borenet@google.com> | Tue Jul 23 08:15:31 2019 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue Jul 23 12:30:50 2019 +0000 |
| tree | 68e953c570cc942c159cf5859112faf853c98c94 | |
| parent | 3217c4474ddd23da32cc87a33528a1a475a0be55 [diff] |
Reland "[task scheduler] Workaround for incorrect job-timeline-sk self-resize" This is a reland of 3bca23b873ac6bf0aafa4090fe748b136ac03c35 Original change's description: > [task scheduler] Workaround for incorrect job-timeline-sk self-resize > > This seems to be a weird interaction between Polymer and D3. It does not > occur in the job-timeline-sk demo page, only in the Task Scheduler UI > itself: upon the first mouseover, the svg gets resized to 600 pixels > wide. If you resize the page a bit, the svg jumps to the appropriate > width, and subsequent mouseovers do not resize the svg further. > > I tracked the resize down to the first call to .attr in layout() and > decided that it made more sense to detect when this occurred and fix it > automatically rather than try to figure out what's going on. > > Change-Id: Ic3562537e3bd7e5332ed71f90fcff44046381dd1 > Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/228997 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com> Change-Id: Ied294ac1a91e0dee072447d0c573f42718948854 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/229256 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
or
$ go get -u -t go.skia.org/infra/...
The latter fetches the repository into your $GOPATH directory along with all the Go dependencies, while the former allows you to work in whatever directory you want. If you're working within GOPATH, you probably want to set this variable:
export GO111MODULE=on
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
The installed python-django version must be >= 1.7. Run the following to update:
$ sudo pip install Django --upgrade
Use this command to run the presubmit tests:
$ ./run_unittests --small