[gold] Refactor search to remove helper types

These types were poorly named and thus had purposes that were
unclear. This CL removes them and makes the flow in search a
little be more linear - we create the return value (a slice
of SRDigest (hopefully to be renamed in a future CL) and
fill in the missing pieces over a few steps.

This refactoring should make it easier to add traces to
CL return values, for example.

Change-Id: I5569af3377c35e8c59e702c740506bdc2d71717d
Bug: skia:9901
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/290867
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
6 files changed
tree: b143b88b6198b1262259ba52cee4f8b32cd0c772
  1. am/
  2. android_compile/
  3. android_ingest/
  4. android_stats/
  5. api/
  6. autoroll/
  7. bash/
  8. blamer/
  9. chromeextensions/
  10. comments/
  11. common-sk/
  12. contestk/
  13. cq_watcher/
  14. ct/
  15. datahopper/
  16. debugger/
  17. debugger-assets/
  18. demos/
  19. docker/
  20. docker_pushes_watcher/
  21. docs/
  22. docserverk/
  23. dot/
  24. ds/
  25. fiddlek/
  26. firestore/
  27. get_service_account/
  28. git_cookie_authdaemon/
  29. gitsync/
  30. go/
  31. gold-client/
  32. golden/
  33. hashtag/
  34. html-template-minifier/
  35. infra/
  36. infra-sk/
  37. jsdoc/
  38. jsfiddle/
  39. k8s-checker/
  40. kube/
  41. leasing/
  42. licenses/
  43. machine/
  44. make/
  45. named-fiddles/
  46. particles/
  47. perdiff/
  48. perf/
  49. periodic-trigger/
  50. power/
  51. proberk/
  52. promk/
  53. pulld/
  54. puppeteer-tests/
  55. push/
  56. res/
  57. scripts/
  58. sheriff_emails/
  59. sk8s/
  60. skbug/
  61. skfe/
  62. skolo/
  63. skottie/
  64. status/
  65. task_driver/
  66. task_scheduler/
  67. tools/
  68. tree_status/
  69. trybot_updater/
  70. velero/
  71. webtools/
  72. .eslintrc.js
  73. .gitattributes
  74. .gitignore
  75. .mocharc.json
  76. build_infra_prod.sh
  77. cipd.ensure
  78. codereview.settings
  79. DATASTORE.md
  80. DEPS
  81. go.mod
  82. go.sum
  83. launch.md
  84. LICENSE
  85. Makefile
  86. package-lock.json
  87. package.json
  88. PRESUBMIT.py
  89. PRIVACY_POLICY.md
  90. README.md
  91. run_unittests
  92. run_unittests.go
  93. STYLEGUIDE.md
  94. tools.go
  95. whitespace.txt
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate
$ npm install -g polylint bower

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \
  github.com/vektra/mockery/...

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small