commit | 22ed2046bf2d1bcb7ae8da90c6868cdadc289b6f | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Mon Oct 05 18:54:40 2020 -0400 |
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Mon Oct 05 23:36:04 2020 +0000 |
tree | fac71b20c1c17c56b11579a673235f9bc4ab851a | |
parent | e69a956e611fc868e5c316a0fb1ee267c12ac3d3 [diff] |
[gold] search-page-sk: Fix bug that hides loading wheel on initial load. Currently the loading wheel on gold-scaffold-sk disappears shortly after the page loads, but before the /json/v1/search RPC completes (this RPC can take several seconds to complete). This is because the initial RPC to /json/v1/search takes place inside the connectedCallback() hook, which is executed before gold-scaffold-sk's connectedCallback() hook. Said hook is where the gold-scaffold-sk adds its listeners for events begin-task and end-task. Therefore gold-scaffold-sk never catches the begin-task event that corresponds to the /json/v1/search RPC, and the loading wheel is not shown. This CL moves the RPC calls out of connectedCallback() and into the stateReflector's setState function. This ensures that the /json/v1/search RPC only takes place after the page is fully loaded (and all connectedCallback() hooks have been invoked), because stateReflector() only calls setState after the "DOMContentLoaded" event has been caught. Bug: skia:9525 Change-Id: I4fc74e5d2b3dc9e6f841cc0cf9196739068923ee Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/322682 Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small