| commit | 173f193b0ee3a972d507489e63d2058c5e579b9c | [log] [tgz] |
|---|---|---|
| author | Leandro Lovisolo <lovisolo@google.com> | Fri Aug 09 14:58:14 2019 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri Aug 09 19:29:33 2019 +0000 |
| tree | 3863ccf71690305eda5bf057777fd9cc08c11f0d | |
| parent | ce054bd88c7a70fde8514a3248422c940ce44c9d [diff] |
[gold] diff.go: Optimize PixelDiff()'s same-size branch by setting each pixel in the output diff exactly once. This results in a ~10% reduction in the time it takes to diff images of different sizes. See benchmarks "BenchmarkDiffDifferentSize" below. Benchmarks before this change: $ go test -bench=. -benchtime=10s goos: linux goarch: amd64 pkg: go.skia.org/infra/golden/go/diff BenchmarkDiffIdentical-12 50000 302783 ns/op BenchmarkDiffSameSize-12 1000 18130019 ns/op BenchmarkDiffDifferentSize-12 500 38916445 ns/op PASS ok go.skia.org/infra/golden/go/diff 61.967s Benchmarks after this change: $ go test -bench=. -benchtime=10s goos: linux goarch: amd64 pkg: go.skia.org/infra/golden/go/diff BenchmarkDiffIdentical-12 50000 296255 ns/op BenchmarkDiffSameSize-12 1000 18129664 ns/op BenchmarkDiffDifferentSize-12 500 34837620 ns/op PASS ok go.skia.org/infra/golden/go/diff 59.099s Bug: skia:9287 Change-Id: Ic87f62f59a33da72702b82ac4d73aa44ea1740a6 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/233464 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small