| commit | a9e01a89bcfe10cf9967aa1e81af21cb20786752 | [log] [tgz] |
|---|---|---|
| author | Jeff Yoon <jeffyoon@google.com> | Thu Dec 19 19:58:06 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Thu Dec 19 16:40:56 2024 -0800 |
| tree | 46bbe90e2120031c08448b2b0e12907eca5a8a86 | |
| parent | ded851d9516f2f5e168f65650a5ac7741cbaa35e [diff] |
[perf] do not send event on mouse down unless shift is held This is Google chart specific. On mouse down, we used to emit an event. This hid the tooltip, but not in a correct manner - you can put the mouse over the selected point and the tooltip would reappear. This change makes it so that the user is required to click close. By doing so selections on both the chart and the plot summary are reset correctly. When the tooltip is selected, meaning it's focused the user can hold shift to figure out the delta. Change-Id: I9fcb40448801f1d00939c9f6e6d8aa3d523da0f9 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/931780 Auto-Submit: Jeff Yoon <jeffyoon@google.com> Commit-Queue: Ashwin Verleker <ashwinpv@google.com> Reviewed-by: Ashwin Verleker <ashwinpv@google.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small