commit | 03c4b6b7b970733f95f3173c5d5fa3efcda08011 | [log] [tgz] |
---|---|---|
author | Kevin Lubick <kjlubick@google.com> | Wed May 06 07:42:26 2020 -0400 |
committer | Kevin Lubick <kjlubick@google.com> | Wed May 06 13:35:58 2020 +0000 |
tree | ac7d0f983708859711f592992af9dd89aa8fd72c | |
parent | cf2d06128d2f83008510df5a54417cefce80572a [diff] |
[gold] Make commenter use searchAPI This attempts to reduce the false positive rate of commenter sending comments when an untriaged digest was first seen on master branch. It does this by leveraging the logic in the search API instead of trying to do its own thing. The search API is hopefully the freshest data with respect to digests seen on master. Additionally, this makes commenter less likely to bug somebody about an untriaged digest that has already been triaged. Using the power of the changelist index, this also lets us estimate to the user how many untriaged digests there are on their CL. Suggested review order: - code_review/types.go - fs_clstore.go - commenter.go - commenter_test.go - Everything else Bug: skia:10218 Change-Id: Ifa8f368c63f725e5d8d1ca474633be3860335bf1 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/287883 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small