[gold] Make commenter use searchAPI

This attempts to reduce the false positive rate of commenter sending
comments when an untriaged digest was first seen on master branch. It
does this by leveraging the logic in the search API instead of trying
to do its own thing. The search API is hopefully the freshest data
with respect to digests seen on master. Additionally, this makes commenter
less likely to bug somebody about an untriaged digest that has already
been triaged.

Using the power of the changelist index, this also lets us estimate to
the user how many untriaged digests there are on their CL.

Suggested review order:
 - code_review/types.go
 - fs_clstore.go
 - commenter.go
 - commenter_test.go
 - Everything else

Bug: skia:10218
Change-Id: Ifa8f368c63f725e5d8d1ca474633be3860335bf1
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/287883
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
8 files changed
tree: ac7d0f983708859711f592992af9dd89aa8fd72c
  1. am/
  2. android_compile/
  3. android_ingest/
  4. android_stats/
  5. api/
  6. autoroll/
  7. bash/
  8. blamer/
  9. chromeextensions/
  10. comments/
  11. common-sk/
  12. contestk/
  13. cq_watcher/
  14. ct/
  15. datahopper/
  16. debugger/
  17. debugger-assets/
  18. demos/
  19. docker/
  20. docker_pushes_watcher/
  21. docs/
  22. docserverk/
  23. dot/
  24. ds/
  25. fiddlek/
  26. firestore/
  27. get_service_account/
  28. git_cookie_authdaemon/
  29. gitsync/
  30. go/
  31. gold-client/
  32. golden/
  33. hashtag/
  34. html-template-minifier/
  35. infra/
  36. infra-sk/
  37. jsdoc/
  38. jsfiddle/
  39. k8s-checker/
  40. kube/
  41. leasing/
  42. licenses/
  43. machine/
  44. make/
  45. named-fiddles/
  46. particles/
  47. perdiff/
  48. perf/
  49. periodic-trigger/
  50. power/
  51. proberk/
  52. promk/
  53. pulld/
  54. puppeteer-tests/
  55. push/
  56. res/
  57. scripts/
  58. sheriff_emails/
  59. sk8s/
  60. skbug/
  61. skfe/
  62. skolo/
  63. skottie/
  64. status/
  65. task_driver/
  66. task_scheduler/
  67. tools/
  68. tree_status/
  69. velero/
  70. webtools/
  71. .eslintrc.js
  72. .gitattributes
  73. .gitignore
  74. .mocharc.json
  75. build_infra_prod.sh
  76. cipd.ensure
  77. codereview.settings
  78. DATASTORE.md
  79. DEPS
  80. go.mod
  81. go.sum
  82. launch.md
  83. LICENSE
  84. Makefile
  85. package-lock.json
  86. package.json
  87. PRESUBMIT.py
  88. PRIVACY_POLICY.md
  89. README.md
  90. run_unittests
  91. run_unittests.go
  92. STYLEGUIDE.md
  93. tools.go
  94. whitespace.txt
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate
$ npm install -g polylint bower

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \
  github.com/vektra/mockery/...

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small