commit | 00f0070c2736b9dbaa118b4b983829a97c16663a | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Thu Oct 01 00:15:40 2020 -0400 |
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Thu Oct 01 17:37:18 2020 +0000 |
tree | 9b24fc755d2996ce81f3726c38c96c8c77ce5b26 | |
parent | d8bbcd4e8747fc8b650a84f769eeb429dd32d45a [diff] |
[infra-sk] PageObjectElement: Replace href() with new, more general method getAttribute(). Turns out the HTMLAnchorElement#href[1] property is generally not what one would like to make assertions against, since it returns the full target URL. For relative paths, this includes the URL of the test runner (e.g. http://localhost:9876), which complicates tests. A better way to make assertions about anchor elements is to query the "href" attribute directly, which is now possible via the getAttribute() method. Note that it is still possible to access the HTMLAnchorElement#href property (or any other property for that matter) via method PageObjectElement#selectOneDOMNodeThenApplyFn(). [1] https://developer.mozilla.org/en-US/docs/Web/API/HTMLHyperlinkElementUtils/href Change-Id: I124a98d861dc3bd94ed8881256a5819789d7d317 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/321378 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small