Remove dialog-polyfill.
The <dialog> element is now supported everywhere: https://caniuse.com/dialog
Change-Id: I0e007fcb82adf6caae90f8b9109f4d2ef9573635
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/580098
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
diff --git a/am/modules/alert-manager-sk/BUILD.bazel b/am/modules/alert-manager-sk/BUILD.bazel
index 58cd694..1bd34e7 100644
--- a/am/modules/alert-manager-sk/BUILD.bazel
+++ b/am/modules/alert-manager-sk/BUILD.bazel
@@ -19,9 +19,7 @@
"//am/modules/paramset:index_ts_lib",
"//am/modules:am_ts_lib",
"//infra-sk/modules:login_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/am/modules/alert-manager-sk/alert-manager-sk.ts b/am/modules/alert-manager-sk/alert-manager-sk.ts
index 0064801..ca9506c 100644
--- a/am/modules/alert-manager-sk/alert-manager-sk.ts
+++ b/am/modules/alert-manager-sk/alert-manager-sk.ts
@@ -23,7 +23,6 @@
import '../email-chooser-sk';
import '../silence-sk';
-import dialogPolyfill from 'dialog-polyfill';
import { diffDate } from 'common-sk/modules/human';
import { CheckOrRadio } from 'elements-sk/checkbox-sk/checkbox-sk';
import { HintableObject } from 'common-sk/modules/hintable';
@@ -261,8 +260,6 @@
this._render();
this.helpDialog = $$('#help', this);
- dialogPolyfill.registerDialog(this.helpDialog!);
-
this.spinner = $$('#busy', this) as SpinnerSk;
this.favicon = $$('#favicon');
diff --git a/am/modules/bot-chooser-sk/BUILD.bazel b/am/modules/bot-chooser-sk/BUILD.bazel
index 448b159..0891b41 100644
--- a/am/modules/bot-chooser-sk/BUILD.bazel
+++ b/am/modules/bot-chooser-sk/BUILD.bazel
@@ -6,9 +6,7 @@
sass_srcs = ["bot-chooser-sk.scss"],
ts_deps = [
"//am/modules/json:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/am/modules/bot-chooser-sk/bot-chooser-sk.ts b/am/modules/bot-chooser-sk/bot-chooser-sk.ts
index 7d5ef50..b7a8064 100644
--- a/am/modules/bot-chooser-sk/bot-chooser-sk.ts
+++ b/am/modules/bot-chooser-sk/bot-chooser-sk.ts
@@ -9,7 +9,6 @@
* </p>
*
*/
-import dialogPolyfill from 'dialog-polyfill';
import { define } from 'elements-sk/define';
import { html, render, TemplateResult } from 'lit-html';
import { $$ } from 'common-sk/modules/dom';
@@ -32,7 +31,6 @@
connectedCallback(): void {
this._render();
this.dialog = $$('dialog', this);
- dialogPolyfill.registerDialog(this.dialog!);
}
/**
diff --git a/am/modules/email-chooser-sk/BUILD.bazel b/am/modules/email-chooser-sk/BUILD.bazel
index c3b5fff..414e026 100644
--- a/am/modules/email-chooser-sk/BUILD.bazel
+++ b/am/modules/email-chooser-sk/BUILD.bazel
@@ -10,9 +10,7 @@
sass_deps = ["//infra-sk:elements-sk_scss"],
sass_srcs = ["email-chooser-sk.scss"],
ts_deps = [
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/am/modules/email-chooser-sk/email-chooser-sk.ts b/am/modules/email-chooser-sk/email-chooser-sk.ts
index d879d27..526279f 100644
--- a/am/modules/email-chooser-sk/email-chooser-sk.ts
+++ b/am/modules/email-chooser-sk/email-chooser-sk.ts
@@ -9,7 +9,6 @@
* </p>
*
*/
-import dialogPolyfill from 'dialog-polyfill';
import { define } from 'elements-sk/define';
import { html, render, TemplateResult } from 'lit-html';
import { $$ } from 'common-sk/modules/dom';
@@ -43,7 +42,6 @@
connectedCallback(): void {
this._render();
this.dialog = $$('dialog', this);
- dialogPolyfill.registerDialog(this.dialog!);
}
/**
diff --git a/bugs-central/modules/bugs-slo-popup-sk/BUILD.bazel b/bugs-central/modules/bugs-slo-popup-sk/BUILD.bazel
index 1917fce..498e411 100644
--- a/bugs-central/modules/bugs-slo-popup-sk/BUILD.bazel
+++ b/bugs-central/modules/bugs-slo-popup-sk/BUILD.bazel
@@ -7,9 +7,7 @@
ts_deps = [
"//bugs-central/modules/json:index_ts_lib",
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/bugs-central/modules/bugs-slo-popup-sk/bugs-slo-popup-sk.ts b/bugs-central/modules/bugs-slo-popup-sk/bugs-slo-popup-sk.ts
index 9726658..13383b4 100644
--- a/bugs-central/modules/bugs-slo-popup-sk/bugs-slo-popup-sk.ts
+++ b/bugs-central/modules/bugs-slo-popup-sk/bugs-slo-popup-sk.ts
@@ -7,7 +7,6 @@
import { define } from 'elements-sk/define';
import { html, TemplateResult } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { $$ } from 'common-sk/modules/dom';
@@ -42,7 +41,6 @@
this.priToSLOIssues = mapOfIssues;
this._render();
this.dialog!.showModal();
- dialogPolyfill.registerDialog(this.dialog!);
}
private displayIssues(): TemplateResult[] {
diff --git a/golden/modules/digest-details-sk/BUILD.bazel b/golden/modules/digest-details-sk/BUILD.bazel
index 5281b4e..b6d873e 100644
--- a/golden/modules/digest-details-sk/BUILD.bazel
+++ b/golden/modules/digest-details-sk/BUILD.bazel
@@ -27,9 +27,7 @@
"//golden/modules:common_ts_lib",
"//golden/modules:rpc_types_ts_lib",
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
"//infra-sk/modules:string_ts_lib",
diff --git a/golden/modules/digest-details-sk/digest-details-sk.ts b/golden/modules/digest-details-sk/digest-details-sk.ts
index 2075a71..7d5c641 100644
--- a/golden/modules/digest-details-sk/digest-details-sk.ts
+++ b/golden/modules/digest-details-sk/digest-details-sk.ts
@@ -20,7 +20,6 @@
import { html } from 'lit-html';
import { errorMessage } from 'elements-sk/errorMessage';
import { fromObject } from 'common-sk/modules/query';
-import dialogPolyfill from 'dialog-polyfill';
import { HintableObject } from 'common-sk/modules/hintable';
import { diffDate } from 'common-sk/modules/human';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
@@ -319,7 +318,6 @@
connectedCallback(): void {
super.connectedCallback();
this._render();
- dialogPolyfill.registerDialog(this.querySelector('dialog.blamelist_dialog')!);
}
/** GroupingsResponse used to derive the correct grouping to use when triaging. */
diff --git a/golden/modules/filter-dialog-sk/BUILD.bazel b/golden/modules/filter-dialog-sk/BUILD.bazel
index 499fdd0..bbe6920 100644
--- a/golden/modules/filter-dialog-sk/BUILD.bazel
+++ b/golden/modules/filter-dialog-sk/BUILD.bazel
@@ -15,9 +15,7 @@
],
ts_deps = [
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/golden/modules/filter-dialog-sk/filter-dialog-sk.ts b/golden/modules/filter-dialog-sk/filter-dialog-sk.ts
index e8befa1..ba3b1e6 100644
--- a/golden/modules/filter-dialog-sk/filter-dialog-sk.ts
+++ b/golden/modules/filter-dialog-sk/filter-dialog-sk.ts
@@ -12,7 +12,6 @@
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
import { live } from 'lit-html/directives/live';
-import dialogPolyfill from 'dialog-polyfill';
import { $$ } from 'common-sk/modules/dom';
import { deepCopy } from 'common-sk/modules/object';
import { ParamSet } from 'common-sk/modules/query';
@@ -146,7 +145,6 @@
super.connectedCallback();
this._render();
this._dialog = $$('dialog.filter-dialog', this);
- dialogPolyfill.registerDialog(this._dialog!);
}
open(paramSet: ParamSet, filters: Filters) {
diff --git a/golden/modules/ignores-page-sk/BUILD.bazel b/golden/modules/ignores-page-sk/BUILD.bazel
index e146107..4919fe9 100644
--- a/golden/modules/ignores-page-sk/BUILD.bazel
+++ b/golden/modules/ignores-page-sk/BUILD.bazel
@@ -21,9 +21,7 @@
"//golden/modules:rpc_types_ts_lib",
"//infra-sk/modules/ElementSk:index_ts_lib",
"//infra-sk/modules:linkify_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/golden/modules/ignores-page-sk/ignores-page-sk.ts b/golden/modules/ignores-page-sk/ignores-page-sk.ts
index 13db92b..3110e50 100644
--- a/golden/modules/ignores-page-sk/ignores-page-sk.ts
+++ b/golden/modules/ignores-page-sk/ignores-page-sk.ts
@@ -6,7 +6,6 @@
*/
import * as human from 'common-sk/modules/human';
-import dialogPolyfill from 'dialog-polyfill';
import { classMap } from 'lit-html/directives/class-map';
import { define } from 'elements-sk/define';
@@ -151,7 +150,6 @@
super.connectedCallback();
this._render();
this.editIgnoreRuleDialog = this.querySelector<HTMLDialogElement>('#edit-ignore-rule-dialog')!;
- dialogPolyfill.registerDialog(this.editIgnoreRuleDialog);
this.editIgnoreRuleSk = this.querySelector<EditIgnoreRuleSk>('edit-ignore-rule-sk')!;
this.confirmDialogSk = this.querySelector<ConfirmDialogSk>('confirm-dialog-sk')!;
}
diff --git a/golden/modules/image-compare-sk/BUILD.bazel b/golden/modules/image-compare-sk/BUILD.bazel
index c0b4869..2d5fe1f 100644
--- a/golden/modules/image-compare-sk/BUILD.bazel
+++ b/golden/modules/image-compare-sk/BUILD.bazel
@@ -15,8 +15,6 @@
ts_deps = [
"//golden/modules:common_ts_lib",
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/golden/modules/image-compare-sk/image-compare-sk.ts b/golden/modules/image-compare-sk/image-compare-sk.ts
index 81104a6..2d505d4 100644
--- a/golden/modules/image-compare-sk/image-compare-sk.ts
+++ b/golden/modules/image-compare-sk/image-compare-sk.ts
@@ -8,7 +8,6 @@
*/
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
import { MultiZoomSk } from '../multi-zoom-sk/multi-zoom-sk';
@@ -109,7 +108,6 @@
connectedCallback(): void {
super.connectedCallback();
this._render();
- dialogPolyfill.registerDialog(this.querySelector('dialog.zoom_dialog')!);
}
get isComputingDiffs(): boolean { return this.computingDiffs; }
diff --git a/golden/modules/multi-zoom-sk/BUILD.bazel b/golden/modules/multi-zoom-sk/BUILD.bazel
index 894bc70..24b57a8 100644
--- a/golden/modules/multi-zoom-sk/BUILD.bazel
+++ b/golden/modules/multi-zoom-sk/BUILD.bazel
@@ -31,9 +31,7 @@
":test_data_ts_lib",
"//golden/modules:common_ts_lib",
"//golden/modules:demo_util_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
],
ts_entry_point = "multi-zoom-sk-demo.ts",
)
diff --git a/golden/modules/multi-zoom-sk/multi-zoom-sk-demo.ts b/golden/modules/multi-zoom-sk/multi-zoom-sk-demo.ts
index aa825e3..6f04efc 100644
--- a/golden/modules/multi-zoom-sk/multi-zoom-sk-demo.ts
+++ b/golden/modules/multi-zoom-sk/multi-zoom-sk-demo.ts
@@ -1,7 +1,5 @@
import './index';
-import dialogPolyfill from 'dialog-polyfill';
-
import { $$ } from 'common-sk/modules/dom';
import { digestDiffImagePath, digestImagePath } from '../common';
import { diff16x16, left16x16, right16x16 } from './test_data';
@@ -83,7 +81,6 @@
// This element demonstrates how to use multi-zoom-sk in a dialog. It is not meant for use on
// puppeteer.
-dialogPolyfill.registerDialog($$('#the_dialog')!);
$$<MultiZoomSk>('#in_dialog')!.details = {
leftImageSrc: digestImagePath('99c58c7002073346ff55f446d47d6311'),
diffImageSrc:
diff --git a/golden/modules/query-dialog-sk/BUILD.bazel b/golden/modules/query-dialog-sk/BUILD.bazel
index a52358b..718683c 100644
--- a/golden/modules/query-dialog-sk/BUILD.bazel
+++ b/golden/modules/query-dialog-sk/BUILD.bazel
@@ -15,9 +15,7 @@
],
ts_deps = [
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/golden/modules/query-dialog-sk/query-dialog-sk.ts b/golden/modules/query-dialog-sk/query-dialog-sk.ts
index b2bd76d..7f1bb80 100644
--- a/golden/modules/query-dialog-sk/query-dialog-sk.ts
+++ b/golden/modules/query-dialog-sk/query-dialog-sk.ts
@@ -17,7 +17,6 @@
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { $$ } from 'common-sk/modules/dom';
import { ParamSet, toParamSet } from 'common-sk/modules/query';
import { QuerySk, QuerySkQueryChangeEventDetail } from '../../../infra-sk/modules/query-sk/query-sk';
@@ -64,7 +63,6 @@
this._render();
this.dialog = $$('dialog', this);
this.querySk = $$('query-sk', this);
- dialogPolyfill.registerDialog(this.dialog!);
}
open(paramSet: ParamSet, selection: string) {
diff --git a/golden/modules/search-page-sk/BUILD.bazel b/golden/modules/search-page-sk/BUILD.bazel
index 72b77c7..fe0ce12 100644
--- a/golden/modules/search-page-sk/BUILD.bazel
+++ b/golden/modules/search-page-sk/BUILD.bazel
@@ -30,9 +30,7 @@
"//golden/modules:rpc_types_ts_lib",
"//golden/modules:settings_ts_lib",
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/golden/modules/search-page-sk/search-page-sk.ts b/golden/modules/search-page-sk/search-page-sk.ts
index 7d12c93..3cb7b16 100644
--- a/golden/modules/search-page-sk/search-page-sk.ts
+++ b/golden/modules/search-page-sk/search-page-sk.ts
@@ -9,7 +9,6 @@
import { deepCopy } from 'common-sk/modules/object';
import { stateReflector } from 'common-sk/modules/stateReflector';
import { fromObject, fromParamSet, ParamSet } from 'common-sk/modules/query';
-import dialogPolyfill from 'dialog-polyfill';
import { HintableObject } from 'common-sk/modules/hintable';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
import { ChangelistControlsSkChangeEventDetail } from '../changelist-controls-sk/changelist-controls-sk';
@@ -194,7 +193,7 @@
private static paginationTemplate = (el: SearchPageSk, cssClass: string) => {
const numResults = el.searchResponse?.size || 0;
- if (numResults == 0 || numResults <= el.limit) {
+ if (numResults === 0 || numResults <= el.limit) {
return html``;
}
return html`
@@ -319,10 +318,8 @@
document.addEventListener('keydown', this.keyDownEventHandlerFn);
this.bulkTriageDialog = this.querySelector('dialog.bulk-triage');
- dialogPolyfill.registerDialog(this.bulkTriageDialog!);
this.helpDialog = this.querySelector('dialog.help');
- dialogPolyfill.registerDialog(this.helpDialog!);
}
disconnectedCallback(): void {
diff --git a/infra-sk/modules/confirm-dialog-sk/BUILD.bazel b/infra-sk/modules/confirm-dialog-sk/BUILD.bazel
index 382ca5d..c637660 100644
--- a/infra-sk/modules/confirm-dialog-sk/BUILD.bazel
+++ b/infra-sk/modules/confirm-dialog-sk/BUILD.bazel
@@ -5,8 +5,6 @@
sass_deps = ["//infra-sk:elements-sk_scss"],
sass_srcs = ["confirm-dialog-sk.scss"],
ts_deps = [
- "@npm//@types/dialog-polyfill",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/infra-sk/modules/confirm-dialog-sk/confirm-dialog-sk.ts b/infra-sk/modules/confirm-dialog-sk/confirm-dialog-sk.ts
index 2b4b120..9860545 100644
--- a/infra-sk/modules/confirm-dialog-sk/confirm-dialog-sk.ts
+++ b/infra-sk/modules/confirm-dialog-sk/confirm-dialog-sk.ts
@@ -23,7 +23,6 @@
*
*/
import { define } from 'elements-sk/define';
-import dialogPolyfill from 'dialog-polyfill';
import { html, render } from 'lit-html';
import 'elements-sk/styles/buttons';
@@ -51,7 +50,6 @@
connectedCallback(): void {
this.render();
this.dialog = this.querySelector('dialog');
- dialogPolyfill.registerDialog(this.dialog!);
}
/**
diff --git a/infra-sk/modules/query-sk/query-sk.ts b/infra-sk/modules/query-sk/query-sk.ts
index e2d13af..2a8b12b 100644
--- a/infra-sk/modules/query-sk/query-sk.ts
+++ b/infra-sk/modules/query-sk/query-sk.ts
@@ -46,7 +46,7 @@
* of all possible valid prefixes with the Go code.
*/
export const removePrefix = (s: string): string => {
- if (s.length == 0) {
+ if (s.length === 0) {
return s;
}
if ('~!'.includes(s[0])) {
diff --git a/machine/modules/device-editor-sk/BUILD.bazel b/machine/modules/device-editor-sk/BUILD.bazel
index 26fb13e..67b9a97 100644
--- a/machine/modules/device-editor-sk/BUILD.bazel
+++ b/machine/modules/device-editor-sk/BUILD.bazel
@@ -14,8 +14,6 @@
sass_srcs = ["device-editor-sk.scss"],
ts_deps = [
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
"//machine/modules/json:index_ts_lib",
diff --git a/machine/modules/device-editor-sk/device-editor-sk.ts b/machine/modules/device-editor-sk/device-editor-sk.ts
index d8b07e8..4c57eb4 100644
--- a/machine/modules/device-editor-sk/device-editor-sk.ts
+++ b/machine/modules/device-editor-sk/device-editor-sk.ts
@@ -9,7 +9,6 @@
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
import { $$ } from 'common-sk/modules/dom';
-import dialogPolyfill from 'dialog-polyfill';
import 'elements-sk/styles/buttons';
import 'elements-sk/checkbox-sk';
import { SwarmingDimensions } from '../json';
@@ -99,8 +98,6 @@
this._render();
this.infoDialog = this.querySelector<HTMLDialogElement>('dialog.info');
this.confirmDialog = this.querySelector<HTMLDialogElement>('dialog.confirm');
- dialogPolyfill.registerDialog(this.infoDialog!);
- dialogPolyfill.registerDialog(this.confirmDialog!);
}
private applyUpdates(): void {
diff --git a/machine/modules/machine-table-columns-dialog-sk/BUILD.bazel b/machine/modules/machine-table-columns-dialog-sk/BUILD.bazel
index 5876829..c04c85d 100644
--- a/machine/modules/machine-table-columns-dialog-sk/BUILD.bazel
+++ b/machine/modules/machine-table-columns-dialog-sk/BUILD.bazel
@@ -16,9 +16,7 @@
"//infra-sk/modules/ElementSk:index_ts_lib",
"@npm//elements-sk",
"@npm//lit-html",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
],
ts_srcs = [
"machine-table-columns-dialog-sk.ts",
diff --git a/machine/modules/machine-table-columns-dialog-sk/machine-table-columns-dialog-sk.ts b/machine/modules/machine-table-columns-dialog-sk/machine-table-columns-dialog-sk.ts
index a6f2745..4d4efa1 100644
--- a/machine/modules/machine-table-columns-dialog-sk/machine-table-columns-dialog-sk.ts
+++ b/machine/modules/machine-table-columns-dialog-sk/machine-table-columns-dialog-sk.ts
@@ -10,7 +10,6 @@
import { $ } from 'common-sk/modules/dom';
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { CheckOrRadio } from 'elements-sk/checkbox-sk/checkbox-sk';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
import 'elements-sk/checkbox-sk';
@@ -48,7 +47,6 @@
super.connectedCallback();
this._render();
this.dialog = this.querySelector<HTMLDialogElement>('dialog');
- dialogPolyfill.registerDialog(this.dialog!);
}
edit(hidden: ColumnTitles[]): Promise<ColumnTitles[] | undefined> {
diff --git a/machine/modules/note-editor-sk/BUILD.bazel b/machine/modules/note-editor-sk/BUILD.bazel
index 53f3c0f..abe0226 100644
--- a/machine/modules/note-editor-sk/BUILD.bazel
+++ b/machine/modules/note-editor-sk/BUILD.bazel
@@ -15,9 +15,7 @@
ts_deps = [
"//infra-sk/modules/ElementSk:index_ts_lib",
"//machine/modules/json:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/machine/modules/note-editor-sk/note-editor-sk.ts b/machine/modules/note-editor-sk/note-editor-sk.ts
index 629b2f2..bdce7ab 100644
--- a/machine/modules/note-editor-sk/note-editor-sk.ts
+++ b/machine/modules/note-editor-sk/note-editor-sk.ts
@@ -7,7 +7,6 @@
import { $$ } from 'common-sk/modules/dom';
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
import { Annotation } from '../json';
import 'elements-sk/styles/buttons';
@@ -48,7 +47,6 @@
super.connectedCallback();
this._render();
this.dialog = this.querySelector<HTMLDialogElement>('dialog');
- dialogPolyfill.registerDialog(this.dialog!);
}
/**
diff --git a/package-lock.json b/package-lock.json
index c2e73ab..20ba598 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -21,7 +21,6 @@
"@types/d3-force": "^2.1.1",
"@types/d3-scale": "^3.2.2",
"@types/d3-selection": "^1.4.3",
- "@types/dialog-polyfill": "^0.5.0",
"@types/express": "^4.17.11",
"@types/google.visualization": "0.0.68",
"@types/howler": "^2.2.3",
@@ -48,7 +47,6 @@
"d3-force": "^2.1.1",
"d3-scale": "^3.2.4",
"d3-selection": "^1.4.2",
- "dialog-polyfill": "^0.5.6",
"elements-sk": "4.1.2",
"eslint": "^7.24.0",
"eslint-config-airbnb-base": "^14.2.1",
@@ -693,11 +691,6 @@
"resolved": "https://npm.skia.org/skia-infra/@types/d3-time/-/d3-time-2.0.0.tgz",
"integrity": "sha512-Abz8bTzy8UWDeYs9pCa3D37i29EWDjNTjemdk0ei1ApYVNqulYlGUKip/jLOpogkPSsPz/GvZCYiC7MFlEk0iQ=="
},
- "node_modules/@types/dialog-polyfill": {
- "version": "0.5.0",
- "resolved": "https://npm.skia.org/skia-infra/@types/dialog-polyfill/-/dialog-polyfill-0.5.0.tgz",
- "integrity": "sha512-OPx+wf/vu47xCh+uPU7CZVcfwBpGEowp7i25rzmyjvjYad9UMvT4McvdrCsAa1+t7KnpRzC4ZfTwk+rAKQD0yw=="
- },
"node_modules/@types/estree": {
"version": "0.0.39",
"resolved": "https://npm.skia.org/skia-infra/@types/estree/-/estree-0.0.39.tgz",
@@ -2186,11 +2179,6 @@
"resolved": "https://npm.skia.org/skia-infra/di/-/di-0.0.1.tgz",
"integrity": "sha1-gGZJMmzqp8qjMG112YXqJ0i6kTw="
},
- "node_modules/dialog-polyfill": {
- "version": "0.5.6",
- "resolved": "https://npm.skia.org/skia-infra/dialog-polyfill/-/dialog-polyfill-0.5.6.tgz",
- "integrity": "sha512-ZbVDJI9uvxPAKze6z146rmfUZjBqNEwcnFTVamQzXH+svluiV7swmVIGr7miwADgfgt1G2JQIytypM9fbyhX4w=="
- },
"node_modules/diff": {
"version": "5.0.0",
"resolved": "https://npm.skia.org/skia-infra/diff/-/diff-5.0.0.tgz",
@@ -7199,11 +7187,6 @@
"resolved": "https://npm.skia.org/skia-infra/@types/d3-time/-/d3-time-2.0.0.tgz",
"integrity": "sha512-Abz8bTzy8UWDeYs9pCa3D37i29EWDjNTjemdk0ei1ApYVNqulYlGUKip/jLOpogkPSsPz/GvZCYiC7MFlEk0iQ=="
},
- "@types/dialog-polyfill": {
- "version": "0.5.0",
- "resolved": "https://npm.skia.org/skia-infra/@types/dialog-polyfill/-/dialog-polyfill-0.5.0.tgz",
- "integrity": "sha512-OPx+wf/vu47xCh+uPU7CZVcfwBpGEowp7i25rzmyjvjYad9UMvT4McvdrCsAa1+t7KnpRzC4ZfTwk+rAKQD0yw=="
- },
"@types/estree": {
"version": "0.0.39",
"resolved": "https://npm.skia.org/skia-infra/@types/estree/-/estree-0.0.39.tgz",
@@ -8314,11 +8297,6 @@
"resolved": "https://npm.skia.org/skia-infra/di/-/di-0.0.1.tgz",
"integrity": "sha1-gGZJMmzqp8qjMG112YXqJ0i6kTw="
},
- "dialog-polyfill": {
- "version": "0.5.6",
- "resolved": "https://npm.skia.org/skia-infra/dialog-polyfill/-/dialog-polyfill-0.5.6.tgz",
- "integrity": "sha512-ZbVDJI9uvxPAKze6z146rmfUZjBqNEwcnFTVamQzXH+svluiV7swmVIGr7miwADgfgt1G2JQIytypM9fbyhX4w=="
- },
"diff": {
"version": "5.0.0",
"resolved": "https://npm.skia.org/skia-infra/diff/-/diff-5.0.0.tgz",
diff --git a/package.json b/package.json
index 406a2aa..9a3b069 100644
--- a/package.json
+++ b/package.json
@@ -19,7 +19,6 @@
"@types/d3-force": "^2.1.1",
"@types/d3-scale": "^3.2.2",
"@types/d3-selection": "^1.4.3",
- "@types/dialog-polyfill": "^0.5.0",
"@types/express": "^4.17.11",
"@types/google.visualization": "0.0.68",
"@types/howler": "^2.2.3",
@@ -46,7 +45,6 @@
"d3-force": "^2.1.1",
"d3-scale": "^3.2.4",
"d3-selection": "^1.4.2",
- "dialog-polyfill": "^0.5.6",
"elements-sk": "4.1.2",
"eslint": "^7.24.0",
"eslint-config-airbnb-base": "^14.2.1",
diff --git a/perf/modules/alerts-page-sk/BUILD.bazel b/perf/modules/alerts-page-sk/BUILD.bazel
index 11c63d6..e4d2679 100644
--- a/perf/modules/alerts-page-sk/BUILD.bazel
+++ b/perf/modules/alerts-page-sk/BUILD.bazel
@@ -17,9 +17,7 @@
"//perf/modules/alert:index_ts_lib",
"//perf/modules/errorMessage:index_ts_lib",
"//perf/modules/json:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/perf/modules/alerts-page-sk/alerts-page-sk.ts b/perf/modules/alerts-page-sk/alerts-page-sk.ts
index 9b3fbe1..7557ef4 100644
--- a/perf/modules/alerts-page-sk/alerts-page-sk.ts
+++ b/perf/modules/alerts-page-sk/alerts-page-sk.ts
@@ -10,7 +10,6 @@
import 'elements-sk/styles/buttons';
import '../../../infra-sk/modules/paramset-sk';
import '../alert-config-sk';
-import dialogPolyfill from 'dialog-polyfill';
import { define } from 'elements-sk/define';
import { fromObject, toParamSet } from 'common-sk/modules/query';
import { html } from 'lit-html';
@@ -156,7 +155,6 @@
this._render();
this.dialog = this.querySelector<HTMLDialogElement>('dialog');
this.alertconfig = this.querySelector<AlertConfigSk>('#alertconfig');
- dialogPolyfill.registerDialog(this.dialog!);
this.openOnLoad();
})
.catch(errorMessage);
diff --git a/perf/modules/calendar-input-sk/BUILD.bazel b/perf/modules/calendar-input-sk/BUILD.bazel
index a6fee6f..e328df2 100644
--- a/perf/modules/calendar-input-sk/BUILD.bazel
+++ b/perf/modules/calendar-input-sk/BUILD.bazel
@@ -10,8 +10,6 @@
sk_element_deps = ["//perf/modules/calendar-sk"],
ts_deps = [
"//infra-sk/modules/ElementSk:index_ts_lib",
- "@npm//@types/dialog-polyfill",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/perf/modules/calendar-input-sk/calendar-input-sk.ts b/perf/modules/calendar-input-sk/calendar-input-sk.ts
index 8cef2e3..0b0c8c8 100644
--- a/perf/modules/calendar-input-sk/calendar-input-sk.ts
+++ b/perf/modules/calendar-input-sk/calendar-input-sk.ts
@@ -10,7 +10,6 @@
*/
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
import 'elements-sk/icon/date-range-icon-sk';
import '../calendar-sk';
@@ -73,8 +72,6 @@
this.dialog = this.querySelector('dialog')!;
this.calendar = this.querySelector<CalendarSk>('calendar-sk');
this.input = this.querySelector('input');
-
- dialogPolyfill.registerDialog(this.dialog);
}
private inputChangeHandler(e: InputEvent) {
diff --git a/perf/modules/cluster-lastn-page-sk/BUILD.bazel b/perf/modules/cluster-lastn-page-sk/BUILD.bazel
index 7cfac4b..254aad5 100644
--- a/perf/modules/cluster-lastn-page-sk/BUILD.bazel
+++ b/perf/modules/cluster-lastn-page-sk/BUILD.bazel
@@ -19,9 +19,7 @@
"//perf/modules/errorMessage:index_ts_lib",
"//perf/modules/json:index_ts_lib",
"//perf/modules/progress:progress_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/perf/modules/cluster-lastn-page-sk/cluster-lastn-page-sk.ts b/perf/modules/cluster-lastn-page-sk/cluster-lastn-page-sk.ts
index 1e5a356..f85b2f1 100644
--- a/perf/modules/cluster-lastn-page-sk/cluster-lastn-page-sk.ts
+++ b/perf/modules/cluster-lastn-page-sk/cluster-lastn-page-sk.ts
@@ -4,7 +4,6 @@
*
* Allows trying out an alert by clustering over a range of commits.
*/
-import dialogPolyfill from 'dialog-polyfill';
import { define } from 'elements-sk/define';
import { fromObject } from 'common-sk/modules/query';
import { html } from 'lit-html';
@@ -330,8 +329,6 @@
this._render();
this.alertDialog = this.querySelector('#alert-config-dialog');
this.triageDialog = this.querySelector('#triage-cluster-dialog');
- dialogPolyfill.registerDialog(this.alertDialog!);
- dialogPolyfill.registerDialog(this.triageDialog!);
this.alertConfig = this.querySelector('alert-config-sk');
this.runSpinner = this.querySelector('#run-spinner');
this.stateHasChanged = stateReflector(
diff --git a/perf/modules/commit-detail-picker-sk/BUILD.bazel b/perf/modules/commit-detail-picker-sk/BUILD.bazel
index 826ba77..8c8dd81 100644
--- a/perf/modules/commit-detail-picker-sk/BUILD.bazel
+++ b/perf/modules/commit-detail-picker-sk/BUILD.bazel
@@ -15,9 +15,7 @@
"//infra-sk/modules/ElementSk:index_ts_lib",
"//perf/modules/errorMessage:index_ts_lib",
"//perf/modules/json:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/perf/modules/commit-detail-picker-sk/commit-detail-picker-sk.ts b/perf/modules/commit-detail-picker-sk/commit-detail-picker-sk.ts
index a744bf3..7378040 100644
--- a/perf/modules/commit-detail-picker-sk/commit-detail-picker-sk.ts
+++ b/perf/modules/commit-detail-picker-sk/commit-detail-picker-sk.ts
@@ -13,7 +13,6 @@
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { jsonOrThrow } from 'common-sk/modules/jsonOrThrow';
import { errorMessage } from '../errorMessage';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
@@ -93,7 +92,6 @@
this._upgradeProperty('selection');
this._render();
this.dialog = this.querySelector('dialog')!;
- dialogPolyfill.registerDialog(this.dialog);
this.updateCommitSelections();
}
@@ -138,7 +136,7 @@
this.range.begin = cids[cids.length - 1].ts;
this.range.end = cids[0].ts;
this._render();
- } catch (error) {
+ } catch (error: any) {
errorMessage(error);
} finally {
this.updatingCommits = false;
diff --git a/perf/modules/explore-sk/BUILD.bazel b/perf/modules/explore-sk/BUILD.bazel
index 0389c8a..35236fc 100644
--- a/perf/modules/explore-sk/BUILD.bazel
+++ b/perf/modules/explore-sk/BUILD.bazel
@@ -25,9 +25,7 @@
"//perf/modules/json:index_ts_lib",
"//perf/modules/progress:progress_ts_lib",
"//perf/modules/window:window_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
"//perf/modules/pivotutil:index_ts_lib",
diff --git a/perf/modules/explore-sk/explore-sk.ts b/perf/modules/explore-sk/explore-sk.ts
index 0af6e1e..25cdcd2 100644
--- a/perf/modules/explore-sk/explore-sk.ts
+++ b/perf/modules/explore-sk/explore-sk.ts
@@ -9,7 +9,6 @@
import { jsonOrThrow } from 'common-sk/modules/jsonOrThrow';
import { stateReflector } from 'common-sk/modules/stateReflector';
import { toParamSet } from 'common-sk/modules/query';
-import dialogPolyfill from 'dialog-polyfill';
import { TabsSk } from 'elements-sk/tabs-sk/tabs-sk';
import { ParamSet as CommonSkParamSet } from 'common-sk/modules/query';
import { HintableObject } from 'common-sk/modules/hintable';
@@ -632,9 +631,7 @@
this.traceID = this.querySelector('#trace_id');
this.csvDownload = this.querySelector('#csv_download');
this.queryDialog = this.querySelector('#query-dialog');
- dialogPolyfill.registerDialog(this.queryDialog!);
this.helpDialog = this.querySelector('#help');
- dialogPolyfill.registerDialog(this.helpDialog!);
// Populate the query element.
const tz = Intl.DateTimeFormat().resolvedOptions().timeZone;
diff --git a/perf/modules/triage-page-sk/BUILD.bazel b/perf/modules/triage-page-sk/BUILD.bazel
index 598e25b..21c135c 100644
--- a/perf/modules/triage-page-sk/BUILD.bazel
+++ b/perf/modules/triage-page-sk/BUILD.bazel
@@ -22,9 +22,7 @@
"//infra-sk/modules/ElementSk:index_ts_lib",
"//perf/modules/errorMessage:index_ts_lib",
"//perf/modules/json:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/perf/modules/triage-page-sk/triage-page-sk.ts b/perf/modules/triage-page-sk/triage-page-sk.ts
index 87ae877..f42c374 100644
--- a/perf/modules/triage-page-sk/triage-page-sk.ts
+++ b/perf/modules/triage-page-sk/triage-page-sk.ts
@@ -7,7 +7,6 @@
* TODO(jcgregorio) Needs working demo page and tests.
*
*/
-import dialogPolyfill from 'dialog-polyfill';
import { define } from 'elements-sk/define';
import { equals, deepCopy } from 'common-sk/modules/object';
import { fromObject } from 'common-sk/modules/query';
@@ -386,7 +385,6 @@
this._render();
this.dialog = this.querySelector('triage-page-sk > dialog');
- dialogPolyfill.registerDialog(this.querySelector('dialog')!);
this.stateHasChanged = stateReflector(
() => (this.state as unknown) as HintableObject,
(state) => {
diff --git a/shaders/modules/edit-child-shader-sk/BUILD.bazel b/shaders/modules/edit-child-shader-sk/BUILD.bazel
index de98de9..ed4ddb4 100644
--- a/shaders/modules/edit-child-shader-sk/BUILD.bazel
+++ b/shaders/modules/edit-child-shader-sk/BUILD.bazel
@@ -16,9 +16,7 @@
"//infra-sk/modules/ElementSk:index_ts_lib",
"//shaders/modules/json:index_ts_lib",
"//shaders/modules/shadernode:index_ts_lib",
- "@npm//@types/dialog-polyfill",
"@npm//common-sk",
- "@npm//dialog-polyfill",
"@npm//elements-sk",
"@npm//lit-html",
],
diff --git a/shaders/modules/edit-child-shader-sk/edit-child-shader-sk.ts b/shaders/modules/edit-child-shader-sk/edit-child-shader-sk.ts
index 32f5ccd..83b23d1 100644
--- a/shaders/modules/edit-child-shader-sk/edit-child-shader-sk.ts
+++ b/shaders/modules/edit-child-shader-sk/edit-child-shader-sk.ts
@@ -9,7 +9,6 @@
import { $$ } from 'common-sk/modules/dom';
import { define } from 'elements-sk/define';
import { html } from 'lit-html';
-import dialogPolyfill from 'dialog-polyfill';
import { ElementSk } from '../../../infra-sk/modules/ElementSk';
import { ChildShader } from '../json';
import { childShaderUniformNameRegex } from '../shadernode';
@@ -48,7 +47,6 @@
this.dialog = $$<HTMLDialogElement>('dialog', this);
this.dialog!.addEventListener('close', () => this.dialogClosed());
this.input = $$<HTMLInputElement>('input', this);
- dialogPolyfill.registerDialog(this.dialog!);
}
/**
